Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Enhance enum supporting fromstr and display and into #1020

Conversation

wbprime
Copy link
Contributor

@wbprime wbprime commented Oct 31, 2024

This pr intended to make generated enum items impl FromStr and Display and Into trait.

Usually an enum (in or not in trading) may have two different usecases: either for integer-compitible values (like Side/OrderType) or for string values (like Market). It's very kind to generate conversion helper for generated Rust enum types. Currently only From was impl for enum types.

  1. FromStr trait

    Consider a Market enum:

    enum Market {
    XSHE, XSHG, 
    }

    A str to Market conversion was usually needed when dealing with external system.

  2. Display trait

    See above Market enum, a Display trait impl was helpful when converting to meaningful string representation for display or presentation purpose.

  3. Into trait

    As a reverse op of From, it is also helpful to get sensible storing data into DB or something similar.

@vyazelenko vyazelenko merged commit 320850d into real-logic:master Nov 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants