Fix warnings.

real-logic · Jun 11, 2024 · e7d6de8 · e7d6de8
1 parent e3a2088
commit e7d6de8
Showing 1 changed file with 19 additions and 17 deletions.
diff --git a/agrona/src/test/java/org/agrona/collections/Object2IntHashMapTest.java b/agrona/src/test/java/org/agrona/collections/Object2IntHashMapTest.java
@@ -135,6 +135,7 @@ void replaceWithOldAndNewValueThrowsIllegalArgumentExceptionIfNewValueIsAMissing
         final IllegalArgumentException exception =
             assertThrowsExactly(IllegalArgumentException.class, () -> map.replace("key", 1, missingValue));
         assertEquals("cannot accept missingValue", exception.getMessage());
+        assertTrue(map.isEmpty());
     }
 
     @Test
@@ -146,6 +147,7 @@ void replaceThrowsIllegalArgumentExceptionIfNewValueIsAMissingValue()
         final IllegalArgumentException exception =
             assertThrowsExactly(IllegalArgumentException.class, () -> map.replace("key", missingValue));
         assertEquals("cannot accept missingValue", exception.getMessage());
+        assertTrue(map.isEmpty());
     }
 
     @Test
@@ -185,7 +187,7 @@ void shouldHandleCollisionAndThenLinearProbe()
         map.put(key, value);
 
         final int collisionKey = key + map.capacity();
-        final int collisionValue = collisionKey;
+        final int collisionValue = collisionKey + 1;
         map.put(Integer.valueOf(collisionKey), collisionValue);
 
         assertThat(map.get(key), is(value));
@@ -206,8 +208,8 @@ void shouldClearCollection()
 
         objectToIntMap.clear();
 
-        assertThat(objectToIntMap.size(), is(0));
         assertEquals(MISSING_VALUE, objectToIntMap.getValue("1"));
+        assertTrue(objectToIntMap.isEmpty());
     }
 
     @Test
@@ -514,7 +516,7 @@ void shouldRemoveEntryAndCompactCollisionChain()
         objectToIntMap.put(Integer.valueOf(13), 13);
 
         final int collisionKey = key + objectToIntMap.capacity();
-        final int collisionValue = collisionKey;
+        final int collisionValue = collisionKey + 1;
 
         objectToIntMap.put(Integer.valueOf(collisionKey), collisionValue);
         objectToIntMap.put(Integer.valueOf(14), 14);
@@ -967,7 +969,6 @@ void getOrDefaultReturnsExistingValue()
         map.put(key, value);
 
         assertEquals(value, map.getOrDefault(key, defaultValue));
-
         assertEquals(value, map.getValue(key));
     }
 
@@ -979,7 +980,6 @@ void getOrDefaultReturnsDefaultValueIfMappingDoesNotExist()
         final int defaultValue = 42;
 
         assertEquals(defaultValue, map.getOrDefault(key, defaultValue));
-
         assertEquals(MISSING_VALUE, map.getValue(key));
     }
 
@@ -1060,12 +1060,13 @@ void mergeReplacesExistingValue()
         final int value = 500;
         final int newValue = 542;
         map.put(key, oldValue);
-        final IntIntFunction remappingFunction = (v1, v2) ->
-        {
-            assertEquals(oldValue, v1);
-            assertEquals(value, v2);
-            return v1 + v2;
-        };
+        final IntIntFunction remappingFunction =
+            (v1, v2) ->
+            {
+                assertEquals(oldValue, v1);
+                assertEquals(value, v2);
+                return v1 + v2;
+            };
 
         assertEquals(newValue, map.merge(key, value, remappingFunction));
 
@@ -1082,12 +1083,13 @@ void mergeDeletesExistingValue()
         final int value = 500;
         map.put(key, oldValue);
         map.put("other", 22);
-        final IntIntFunction remappingFunction = (v1, v2) ->
-        {
-            assertEquals(oldValue, v1);
-            assertEquals(value, v2);
-            return missingValue;
-        };
+        final IntIntFunction remappingFunction =
+            (v1, v2) ->
+            {
+                assertEquals(oldValue, v1);
+                assertEquals(value, v2);
+                return missingValue;
+            };
 
         assertEquals(missingValue, map.merge(key, value, remappingFunction));