Add webpack commands into setup.py #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a POC that shows building webpack through standard `setup.py` commands. Any call to `setup.py build` or `bdist` or `sdist` will trigger a Webpack build of the assets first. A non-zero exit code will halt the process. Also, moved the `npm run dev` command, which here is `python setup.py watch`, though there is perhaps something better here. There is already `python setup.py develop`, which has a separate function, so I don't want to collide there. Example output here: https://gist.github.com/agjohnson/cdaab364fe598daa7f3bef750cfb84dd Refs #797
jessetan
requested changes
Aug 21, 2019
Co-Authored-By: Jesse Tan <[email protected]>
Co-Authored-By: Jesse Tan <[email protected]>
jessetan
approved these changes
Oct 3, 2019
Closed
|
Fetching stuff from the web during build-time is bad practice, please don't do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a POC that shows building webpack through standard
setup.pycommands. Any call to
setup.py buildorbdistorsdistwilltrigger a Webpack build of the assets first. A non-zero exit code will
halt the process.
Also, moved the
npm run devcommand, which here ispython setup.py watch, though there is perhaps something better here. There is alreadypython setup.py develop, which has a separate function, so I don'twant to collide there.
Example output here:
https://gist.github.com/agjohnson/cdaab364fe598daa7f3bef750cfb84dd
Refs #797