-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wyrm_addons/pygments #504
Conversation
This is not ready for review because I still need to fix things like text and spacing in our own sass |
This is ready for review now |
Looks pretty good as far as I can see, although the |
sass/_theme_rst.sass
Outdated
padding: $base-line-height / 2 $base-line-height / 2 | ||
font-family: $code-font-family | ||
font-size: 12px | ||
line-height: normal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-size
and line-height
can be moved to a new CSS rule for line numbering and actual code. That will prevent them from going out of sync in future.
pre.literal-block, div[class^='highlight'] pre, .linenodiv pre
font-size: 12px
line-height: normal
Adding pre.literal-block
to this rule also aligns the font size for literal blocks, which look out of place now:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
sass/_theme_rst.sass
Outdated
margin: 0 | ||
padding: $base-line-height / 2 $base-line-height / 2 | ||
font-family: $code-font-family | ||
font-size: 12px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps font-size: $base-font-size * 0.75
?
(Also in other places in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a new behavior correct? Seems fine but maybe this is better for another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior would be the same ($base-font-size
is 16px), but indeed perhaps better to move to a new PR that adds a $code-font-size
in _theme_variables.sass
so we can be sure we have consistent font sizes.
Fixes #503 By removing wyrm_addons/pygments we get full support of using native pygments to style code blocks