-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show version for Sphinx and this template in footer. #1410
Conversation
Great, thanks for following up @marxin 👍 Before making adjustments in the PR, I want to hear from @agjohnson if he's fine with adjusting the text of the footer as well.
Looks like: Motivation: The version string looks odd next to "a theme", I think it's because it's very specific to mention the theme version but not its name. This is also shorter. It should be clear from the name "sphinx-rtd-theme" that it's a theme :) |
Go ahead! I'm fine with that. |
@benjaoming: May I please remind you this PR? |
Can you please merge it now? |
I'm good with this. @agjohnson for context, this adds version strings that are really really helpful to be able to diagnose issues with Sphinx/theme faster. |
Why this PR is closed? |
I'm sorry, but the pull request is quite stalled and I've lost interest in the meantime. |
Fine :( |
Let's continue here where we ended in #1269.
@benjaoming edit:
Fixes #1327