This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 252
Adds support for basic markdown tables using the Markdown parser #138
Closed
clayrisser
wants to merge
17
commits into
readthedocs:master
from
clayrisser:codejamninja/python-markdown
Closed
Adds support for basic markdown tables using the Markdown parser #138
clayrisser
wants to merge
17
commits into
readthedocs:master
from
clayrisser:codejamninja/python-markdown
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2019
Closed
This is a huge PR. Did you implement the full RST markdown parser, or did that come from somewhere else? This also has no user-facing documentation around the differences between the parsers, so that would be the minimum required before merging. It's a lot of code to look at though, so I'm not sure when I'll have time to review it more heavily. |
I ended up just forking recommonmark and publishing it with the markdown parser as sphinx-markdown-parser. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #68
This fixes issue #3
This not only enables full markdown support using the Markdown python module but also opens the door for more features supported by the Markdown modules various extensions.
I have ensured this pull request is fully backward compatible with the CommonMark parser.
In order to use the Markdown parser this pull request implements, you have to explicitly set the
parser
property in therecommonmark_config
toMarkdown
.For Sphinx-1.3 you can add it by replacing
CommonMarkParser
withMarkdownParser
You can see my code at the link below.
https://github.com/codejamninja/recommonmark/tree/codejamninja/python-markdown