Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for subproject select renamed "Child" => "Subproject" + help text added #9829

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Dec 20, 2022

In #9785, we are looking for a more consistent terminology.

A new helpful text is also added to explain what the page is about and where the documentation is.

image

@benjaoming benjaoming requested review from a team as code owners December 20, 2022 18:53
@benjaoming benjaoming requested a review from agjohnson December 20, 2022 18:53
@benjaoming benjaoming changed the title Subproject form label for subproject select Subproject form label for subproject select renamed "Child" => "Subproject" Dec 20, 2022
@benjaoming benjaoming changed the title Subproject form label for subproject select renamed "Child" => "Subproject" Label for subproject select renamed "Child" => "Subproject" + help text added Dec 20, 2022
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 on adding actual helptext.

readthedocs/projects/forms.py Outdated Show resolved Hide resolved
@benjaoming benjaoming requested a review from humitos December 22, 2022 14:21
@benjaoming benjaoming merged commit ae91a51 into readthedocs:main Dec 22, 2022
@benjaoming benjaoming deleted the subproject-form-label-for-subproject-select branch December 22, 2022 17:48
@ericholscher
Copy link
Member

Thanks for fixing the code instead of documenting around it @benjaoming. A pro move :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants