Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: path is trimmed when returned by the API #9824

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 20, 2022

This commit contains the test that was missing for my other PR: #9815

The test checks the commands' PATH are trimmed before being returned by the API.

This commit contains the test that was missing for my other PR:
#9815

The test checks the commands' PATH are trimmed before being returned by the API.
@humitos humitos self-assigned this Dec 20, 2022
@humitos humitos requested a review from a team as a code owner December 20, 2022 09:21
@humitos humitos requested a review from ericholscher December 20, 2022 09:21
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks good, along with the test @stsewd is doing to test writing which was also broken. 👍

@humitos humitos merged commit 7bf6ee7 into main Dec 21, 2022
@humitos humitos deleted the huimtos/test-build-command-path branch December 21, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants