Badge: exclude duplicated builds #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
exclude-dup-builds-badge
branch
from
ed7c12d to
1311bec
Compare
ericholscher
approved these changes
Mar 16, 2021
| ).order_by('-date').first() | ||
| last_build = ( | ||
| version.builds | ||
| .filter(type='html', state='finished') |
There was a problem hiding this comment.
I feel like we have another bug where builds are default set to finished when they are created. We should probably change that as well so we don't hit this as well 👍
There was a problem hiding this comment.
Do you mean this is another problem (not something I need to change here)?
There was a problem hiding this comment.
Yea, it can be done in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8015