-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: guide about reproducible builds #7888
Conversation
db66311
to
4598380
Compare
4598380
to
3478c2a
Compare
@stsewd happy to collaborate with you here. 😄 I and @ericholscher discussed a basic outline for the guide in the PyCascades 2021 sprints. Feel free to look into it in the issue and suggest more changes to it. |
I find that implausible given that I didn't attend PyCascades 2021 and haven't lived near the cascades for over a year! |
Sorry 😅 @eric-wieser I mistakenly tagged you. Updated the original comment. |
Sure! Feel free to send a PR with this as base so is easy to review your changes |
- conda-forge | ||
- defaults | ||
dependencies: | ||
- sphinx==3.4.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, core dependencies can't be pinned in conda environment files at the moment, right? #3829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it again to be sure, Sphinx gets overridden https://readthedocs.org/projects/rtd-conda-test/builds/13122163/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be pinned. However, CONDA_APPEND_CORE_REQUIREMENTS
feature flag has to be enabled in the project by the core team: https://docs.readthedocs.io/en/stable/guides/feature-flags.html#feature-flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, for future build tests, we have this repository https://github.com/readthedocs/test-builds where we have one test case per branch (properly named) with the use case that it's testing described in the homepage/index 😉
(you can create a PR instead of a branch since you don't have permissions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be pinned. However, CONDA_APPEND_CORE_REQUIREMENTS feature flag has to be enabled in the project by the core team
I'm tempted to add a note about that here, but I think maybe we should push to make that the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Let's ship it!
Co-authored-by: Eric Holscher <[email protected]>
Tried to keep it short, simple and easy to copy/pasta, I think this replaces the other guide.
Close #7852