Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove domain verify signal and task #7763

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Remove domain verify signal and task #7763

merged 1 commit into from
Dec 21, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 16, 2020

This happens in a periodic task every five minutes now.
There are other PRs to delete more code in -corp and -ext.

@stsewd
Remove domain verify signal and task
977e026 
This happens in a periodic task every five minutes now.
There are other PRs to delete more code in -corp and -ext.
@stsewd stsewd requested a review from a team December 16, 2020 19:29
agjohnson
agjohnson reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I noted in the ext PR, but if we aren't using this signal as the only mechanism to update cloudflare domains, then this seems fine.

@stsewd stsewd mentioned this pull request Dec 17, 2020
Closed
@ericholscher ericholscher merged commit f8fa96a into master Dec 21, 2020
@ericholscher ericholscher deleted the remove-retry-signal branch December 21, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @ericholscher @agjohnson