Display sidebar ad when scrolled #7621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a JS bug around ad display when linked directly to an anchor somewhat down the page. By default, we display an ad in the sidebar if it would be visible without scrolling the sidebar (who does that?) and put it in the footer otherwise. The math was slightly off on whether the bottom of the sidebar would be visible if the window was already scrolled.
|
The CI error is unrelated. |
Looks like you need to update your branch to match the changes from master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a JS bug around ad display when linked directly to an anchor somewhat down the page. By default, we display an ad in the sidebar if it would be visible without scrolling the sidebar (who does that?) and put it in the footer otherwise. The math was slightly off on whether the bottom of the sidebar would be visible if the window was already scrolled.
Testing steps