Ads JS hotfix #7586
Merged
Ads JS hotfix #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidfischer
commented
Oct 20, 2020
davidfischer
commented
- Fix an issue with the publisher not being set correctly
- Don't make the API call at all if ads are disabled
- Fix an issue with the publisher not being set correctly - Don't make the API call at all if ads are disabled
davidfischer
commented
Oct 20, 2020
| @@ -177,7 +185,7 @@ function init() { | |||
| error: function () { | |||
| console.error('Error loading Read the Docs user and project information'); | |||
|
|
|||
| if (!rtd.ad_free && rtd.api_host === 'https://readthedocs.org' && detect_adblock()) { | |||
There was a problem hiding this comment.
This isn't needed because it's checked on line 139 above.
ericholscher
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.