Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper div names on our ad placements #7493

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

ericholscher
Copy link
Member

This will be deprecated here soon,
but for now this will make that data more clean.

This will be deprecated here soon,
but for now this will make that data more clean.
@ericholscher ericholscher requested a review from a team September 18, 2020 00:26
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I have the context about this change. I guess we just want human-readable names here but don't really know how/where they are used. We may want to keep the postfix random number as it was, tho: rtd-explicit-2918.

@ericholscher
Copy link
Member Author

Why do we want the random number?

@humitos
Copy link
Member

humitos commented Sep 21, 2020

I don't have the answer to that, but I suppose that it was added for some reason 😅, obfuscate or avoid id collisions, perhaps?

@ericholscher
Copy link
Member Author

I talked with David, and these were originally done for ad blocking, but it didn't work :) So I think they are safe to remove, tho this code will be removed in a couple weeks anyway, so I'm fine if this doesn't ship.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@ericholscher ericholscher merged commit d859017 into master Sep 28, 2020
@ericholscher ericholscher deleted the sponsorship-proper-divs branch September 28, 2020 18:06
@stsewd stsewd mentioned this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants