Footer: don't show the version warning for external version #7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Jul 29, 2020
| if ( | ||
| not project.show_version_warning or | ||
| (base_version and base_version.is_external) | ||
| ): | ||
| return {'is_highest': False} |
There was a problem hiding this comment.
Is there a reason we're setting this to False here instead of True? Seems if we're opting out of showing it, setting it to True makes more sense, even though I know we likely aren't testing for it.
There was a problem hiding this comment.
Just to avoid running the queries below, that value is only used for the warning message.
There was a problem hiding this comment.
Gotcha -- just seems like True is a better default for other edge cases, but I don't care too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7218