Reduce robots.txt cache TTL #7334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TTL on the cache_page call of 12 hours exceeds the expiration of the S3 presign URL expiration TTL. I believe the default here is the `AWS_QUERYSTRING_EXPIRE` setting, default 3600s: https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html#settings Going beyond expiration on the presign URL results in a broken response to the user, so not something we can safely keep cached. 12 hours is likely far too agressive here anyways. We could likely drop this to a sub-5m TTL. If this is cached because it's an expensive view, an hour seems like a good compromise for now.
humitos
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TTL on the cache_page call of 12 hours exceeds the expiration of the
S3 presign URL expiration TTL. I believe the default here is the
AWS_QUERYSTRING_EXPIREsetting, default 3600s:https://django-storages.readthedocs.io/en/latest/backends/amazon-S3.html#settings
Going beyond expiration on the presign URL results in a broken response
to the user, so not something we can safely keep cached.
12 hours is likely far too agressive here anyways. We could likely drop
this to a sub-5m TTL. If this is cached because it's an expensive view,
an hour seems like a good compromise for now.