Use CharField.choices for Build.status_code
#7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to communicate more than True/False status in this field. This will help us to render different error messages to the user depending on the `Build.status_code`.
ericholscher
approved these changes
Jun 8, 2020
|
@ericholscher please, take a look at this again. We do need this to be merged before the release. |
agjohnson
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
This looks good to me! 👍
In the future, using a registry pattern for our errors/statuses would save on duplicating status/error class attributes in our model's choice list, so maybe choices won't be the field type we ultimately use here. This is still a good step forward either way, and we can easily change this if we change our minds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to communicate more than True/False status in this field.
This will help us to render different error messages to the user depending on
the
Build.status_code.#7123 was approved and merged, but I missed that usage of
status_codethere (I don't know why I used a boolean 🤷) but that is incorrect.Also from #7123 (comment), I think it's better to use a
CharField.choicesthat will communicate better the meaning, instead of a plain number.