Search: track total results #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
May 14, 2020
Comment on lines
+38
to
+39
| # TODO: to avoid downtime, remove later. | ||
| null=True, |
There was a problem hiding this comment.
If it's ok to not save some search queries during deploy I can just remove this.
ericholscher
approved these changes
May 14, 2020
|
@ericholscher are we ok showing 0 results for old queries? Looks like integerfield treats None as 0, so I can't check for None for the old queries.
|
|
@stsewd yea I think thats fine for now. It will slowly fill in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7047