Fix tests ahead of django-dynamic-fixture update #7073
Conversation
|
Looks like the following tests keep failing because
|
santos22
changed the title
| @@ -166,6 +166,7 @@ def test_trigger_build_invalid_time_limit(self, update_docs): | |||
| def test_trigger_build_rounded_time_limit(self, update_docs): | |||
| """Time limit should round down.""" | |||
| self.project.container_time_limit = 3 | |||
| self.project.build_queue = 'build_queue' | |||
There was a problem hiding this comment.
Not sure why we need this to make the tests pass. Where are we expecting this to be set?
There was a problem hiding this comment.
This was the last build that failed:
https://travis-ci.org/github/readthedocs/readthedocs.org/jobs/688452656
There was a problem hiding this comment.
There are AssertionErrors near the bottom.
There was a problem hiding this comment.
For those cases, we just need to delete the expected value of queue 'queue': mock.ANY,
There was a problem hiding this comment.
Will go ahead and remove 👍
|
Oh. I was not getting those test failures. Will fix them too... Guess the build stops automatically when it encounters test failures and you can't see if there are more test failures until you fix the first set. |
Closes #6886
Latest pyup dependency update - #7012
There were a couple of tests failing locally that looked unrelated to the django-dynamic-fixure upgrade:
test_privacy_urls.py(fixed)test_core_utils.py(fixed)