Example about how to kill a running task #7031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
We are de-duplicating builds for now, only. Not cancelling already running builds. |
humitos
added a commit
that referenced
this pull request
Jan 26, 2022
We tried to implement this in another opportunities (see #7031) but the build process was really complex and we had to manage the exception in multiple places. After implementing Celery Handlers, we can just raise the exception when attending to the proper signal coming from `app.control.revoke` and handle it properly from `on_failure` task's method. All the initial local tests were great!
humitos
added a commit
that referenced
this pull request
Feb 22, 2022
We tried to implement this in another opportunities (see #7031) but the build process was really complex and we had to manage the exception in multiple places. After implementing Celery Handlers, we can just raise the exception when attending to the proper signal coming from `app.control.revoke` and handle it properly from `on_failure` task's method. All the initial local tests were great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an example of how to cancel an already triggered build.
From what I've seen, it would be good to implement #3984 before working on a solution to cancel builds. Or, implement only the part needed for now to handle the
BuildKilledexception.I think implementing that issue first is better because otherwise, we need to handle the exception
BuildKilledin many different places inside the code of the task itself:The current implementation "works", but it's not handling the exception in all the places needed. So, depending when you click on "Cancel build" you will get a gracefully killed build (proper set of all the attributes --
success=False, etc) or a hard killed build.