-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a custom Task Router to route tasks dynamically #6849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/task-routing
branch
from
April 2, 2020 14:52
7596837
to
8be9f85
Compare
stsewd
reviewed
Apr 2, 2020
humitos
force-pushed
the
humitos/task-routing
branch
from
April 2, 2020 15:34
8be9f85
to
1d1737c
Compare
humitos
force-pushed
the
humitos/task-routing
branch
from
April 2, 2020 15:47
1d1737c
to
413c950
Compare
humitos
force-pushed
the
humitos/task-routing
branch
from
April 2, 2020 16:02
413c950
to
e876613
Compare
ericholscher
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should standardize on one way to return the deafult queue. I prefer returning None
, and letting Celery handle it, since it reduces our logic.
…docs.org into humitos/task-routing
I'm 👍 on merging & shipping this once tests are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an example using a Celery Task Router (under a Feature flag for now) to route tasks based on some project properties and queue's length. I think this could help us to get the most of the
build:default
queue without loosing performance on projects that don't really fit there and "auto-scale" projects to a bigger server when building time is getting closer to the limit.The logic behind this, is that it will route the task to
build:large
in any of these cases:(it ignores projects that have already set
build_queue
attribute)I tested it with our current Docker Compose setup and I does the routing properly.