Rework custom domains docs #6844
Conversation
- Merge docs for custom domains for .org and .com - Merge `Custom domain support` and `Custom Domain SSL` sections - Simplify some paragraphs
It might be worth writing a small amount of JS that lets us change the active tab in a link. I don't think it would be hard to do (eg. |
Or, even better... #6621 |
Co-Authored-By: Eric Holscher <[email protected]>
Yeah, I'll see if I can implement it in the extension itself. |
|
I wrote a little js file to allow us to expand a tab, the sphinx-tabs repo looks like a little abandoned https://github.com/djungelorm/sphinx-tabs/pulls, I'll see if I can implement this later in the original extension, to allow us to link from a role |
|
The only thing missing is what to do with the |
Yea, I think thats a good idea for now. |
|
It would be cool if the JS updated the URL when you switched tabs, but that might be too much for now 👍 |
| if (tabName !== null) { | ||
| const tab = $('a.item > div:contains("' + tabName + '")'); | ||
| if (tab.length > 0) { | ||
| tab.click(); |
There was a problem hiding this comment.
💯
This is maybe a good suggestion for upstream 😄
|
I created the redirect! |
|
https://docs.readthedocs.io/en/latest/commercial/custom_domains.html redirects correctly! |
Custom domain supportandCustom Domain SSLsectionsI'm not sure what to do with the
Proxy SSLsection, looks like we don't support this on .com? Or do we want to support this for new projects on .org?And I was about to remove the dig example, not sure.
preview at https://docs--6844.org.readthedocs.build/en/6844/custom_domains.html
One downside is that we can't link to a tab (executablebooks/sphinx-tabs#47).
But we could make the .com tab the default if we want.
Note: we need to create a redirect after this is released