Run proxito tests with proxito #6714
Conversation
| @@ -213,6 +213,7 @@ def test_project_nginx_serving_unicode_filename(self): | |||
| @override_settings( | |||
| PYTHON_MEDIA=False, | |||
| PUBLIC_DOMAIN='readthedocs.io', | |||
| RTD_BUILD_MEDIA_STORAGE='readthedocs.rtd_tests.storage.BuildMediaFileSystemStorageTest', | |||
There was a problem hiding this comment.
Only this test was expecting to use readthedocs.rtd_tests.storage.BuildMediaFileSystemStorageTest instead of readthedocs.proxito.tests.storage.BuildMediaStorageTest, couldn't figure out how to make it work with the other one
| url = reverse('search') | ||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def setup(self): | ||
| self.url = reverse('search') |
There was a problem hiding this comment.
Had to change this, because pytest evaluates/import the file, in proxito we don't have search (yet)
| commands = | ||
| pytest --cov-report= --cov-config {toxinidir}/.coveragerc --cov=. --suppress-no-test-exit-code {posargs:{env:TOX_POSARGS:-m 'not search'}} | ||
| /bin/sh -c '\ | ||
| export DJANGO_SETTINGS_MODULE=readthedocs.settings.test; \ | ||
| pytest --cov-report= --cov-config {toxinidir}/.coveragerc --cov=. --suppress-no-test-exit-code -m "not proxito" {posargs:{env:TOX_POSARGS:-m "not search and not proxito"}}' |
There was a problem hiding this comment.
-m "not proxito" {posargs:{env:TOX_POSARGS:-m "not search and not proxito"}}
It's hard to make everyone happy :D. So, -m doesn't combine the multiple -m, but it takes the last -m option, so search tests and proxito tests aren't run by default. And proxito tests won't run for people that wants to run search tests.
Just for clarification, proxito tests won't run with this command, but they will in the command below.
|
@stsewd is the approach of using flags and |
|
@ericholscher docs explaining this at #6764 |
|
Also, this allows us to not hardcode the urls to |
No description provided.