Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use an instance of VCS when isn't needed #6548

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Don't use an instance of VCS when isn't needed #6548

merged 3 commits into from
Jan 23, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 20, 2020

We were creating an instance just to get the fallback branch.

Related to #6546

@stsewd
Don't use an instance of VCS when isn't needed
55b156c 
We were creating an instance just to get the fallback branch.

Related to readthedocs#6546
@stsewd stsewd requested a review from a team January 20, 2020 20:42
ericholscher
ericholscher approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. A couple cleanup items.

readthedocs/projects/models.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit cd7265f into readthedocs:master Jan 23, 2020
@stsewd stsewd deleted the dont-use-instance-when-isnot-needed branch January 23, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher