-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Transifex Integration details in Internationalization page. #6531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we shouldn't change the call from scripts to python code. The examples should use invoke
docs/development/i18n.rst
Outdated
|
||
#. Update files and push sources (English) to Transifex: | ||
|
||
.. prompt:: bash $ | ||
.. code-block:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a bash call too, but using invoke
docs/development/i18n.rst
Outdated
|
||
.. prompt:: bash $ | ||
.. code-block:: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@stsewd Thanks for the review. I'll update the PR with the required changes. |
@stsewd I have made the changes that were requested. It is ready for review. Screenshot: |
docs/development/i18n.rst
Outdated
|
||
.. _fabric script: https://github.com/readthedocs/readthedocs.org/blob/master/fabfile.py | ||
.. _Invoke: http://www.pyinvoke.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. _Invoke: http://www.pyinvoke.org/ | |
.. _Invoke: https://www.pyinvoke.org/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change that and update the commit.
This commit changes the bad link to fabfile.py to tasks.py file in Internationalization page.
@stsewd Thanks for the review. I have changed http to https. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks, looking forward to contributing more. |
This commit changes the bad link to fabfile.py to tasks.py file in Internationalization page.
Fixes #6525.