Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose env variables on external versions #6440

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Do not expose env variables on external versions #6440

merged 1 commit into from
Dec 5, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 5, 2019

This avoid exposing potential secrets when a PR is opened.

@humitos
Do not expose env variables on external versions
aebf5c5 
This avoid exposing potential secrets when a PR is opened.
@humitos humitos requested a review from ericholscher December 5, 2019 15:09
ericholscher
ericholscher approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense -- could probably use a test if it's easy to test, just to make sure we don't break it in the future 👍

@humitos humitos merged commit 4ac8ec1 into master Dec 5, 2019
@humitos humitos deleted the humitos/not-expose-env-external branch December 5, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher