Small optimization to not compute the highest version when it isn't displayed #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
approved these changes
Nov 7, 2019
…isplayed We added a setting about whether to show this to the user or not, but always calculated the data regardless of the setting.
stsewd
force-pushed
the
dont-compute-highest-if-not-shown
branch
from
8300f63 to
6acceea
Compare
stsewd
reviewed
Nov 13, 2019
| @@ -152,7 +171,7 @@ def test_highest_version_from_lower(self): | |||
| self.assertDictEqual(valid_data, returned_data) | |||
|
|
|||
| def test_highest_version_from_latest(self): | |||
| Version.objects.create_latest(project=self.pip, built=True) | |||
| self.pip.versions.filter(slug=LATEST).update(built=True) | |||
There was a problem hiding this comment.
latest is created when we call pip.save() in the setup method
|
Tests should be passing now |
It should not affect it. The extension does not use the footer API, it uses the |
humitos
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a setting about whether to show this to the user or not,
but always calculated the data regardless of the setting.
@humitos does this break your extension, or is it respecting this setting also?