Remove files from storage and delete indexes from ES when no longer needed #6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
clean-project-resources
branch
from
a2b4cb1 to
ccddefd
Compare
stsewd
force-pushed
the
clean-project-resources
branch
from
ccddefd to
a2eb682
Compare
|
Tested this locally, it's ready for review. Test faillin is fixed in #6317 |
dojutsu-user
approved these changes
Oct 23, 2019
davidfischer
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are not removing files from storage when a version is deactivated. And we are not removing indexes from ES when a project/version is deleted or a version is deactivated.
Have to refactor
remove_indexed_filesto accept a slug instead of an instance, so we avoid having to make a query.