Refactor Gold Views #6272
Merged
Refactor Gold Views #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
requested changes
Oct 30, 2019
| <li> | ||
| <form method="post" action="{% url "gold_projects_remove" project.slug %}"> | ||
| {% csrf_token %} | ||
| <input type="submit" value="{% trans 'Remove Ad-Free Status' %}"> |
There was a problem hiding this comment.
Remove ad free status is a lot for a button, it's better to keep text on buttons to a minimum or rely on icons instead. When translators go to translate this string, it could easily become a string that is too wide for the list view.
There was a problem hiding this comment.
I have added a tool tip with the remove button.
| {% endfor %} | ||
| </ul> | ||
|
|
||
| <div class="module-translation"> |
There was a problem hiding this comment.
This probably shouldn't be module-translation, which is referencing the translation admin UI.
agjohnson
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5856
Changed a bit of the template otherwise had to do hack like this: #6242 (comment)
