Put view under login #6193
Merged
Put view under login #6193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,7 +210,7 @@ def account_advertising(request): | |||
| ) | |||
|
|
|||
|
|
|||
| class TokenMixin: | |||
There was a problem hiding this comment.
Is this the actual bugfix here?
There was a problem hiding this comment.
Yeah, otherwise an anonymous user could hit that page, it was returning 500. There was a discussion on slack, sorry for the lack of context.
humitos
reviewed
Oct 2, 2019
Co-Authored-By: Manuel Kaufmann <[email protected]>
…org into put-page-under-login
|
Just for clarification, this PR fix this problem https://readthedocs.org/accounts/tokens/ (enter without being loged in) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, we were implementing our own LoginRequiredMixin, but we already have this on django.