Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProjectTranslations views #6185

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Refactor ProjectTranslations views #6185

merged 3 commits into from
Oct 2, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 16, 2019

ref #5856

This should be refactored to only use post to delete.

@stsewd stsewd requested a review from a team September 17, 2019 15:21
humitos
humitos approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I just left some minor comments.

readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
readthedocs/projects/views/private.py Show resolved Hide resolved
readthedocs/projects/views/private.py Outdated Show resolved Hide resolved
@stsewd stsewd merged commit 494abb3 into readthedocs:master Oct 2, 2019
@stsewd stsewd deleted the refactor-project-translations-views branch October 2, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos