-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Builder GitLab Integration #6066
PR Builder GitLab Integration #6066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. A few small nits, but I think it's close.
return identifier, verbose_name | ||
|
||
except KeyError: | ||
raise ParseError('Parameters "id" and "iid" are required') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this ParseError
handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is a ParseError
we return 400
to the API. We do the same thing for the push
events.
readthedocs.org/readthedocs/api/v2/views/integrations.py
Lines 468 to 472 in e53af66
try: | |
branches = [self._normalize_ref(data['ref'])] | |
return self.get_response_push(self.project, branches) | |
except KeyError: | |
raise ParseError('Parameter "ref" is required') |
Co-Authored-By: Eric Holscher <[email protected]>
…org into gitlab-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ref: #6052