Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RTD prefix for docker only in setting.py and all other places where is needed #6040

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

Iamshankhadeep
Copy link
Contributor

fixes #5586

@stale
Copy link

stale bot commented Sep 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Sep 19, 2019
@dojutsu-user dojutsu-user removed the Status: stale Issue will be considered inactive soon label Sep 19, 2019
@stsewd stsewd requested review from stsewd and a team September 19, 2019 15:26
@Iamshankhadeep
Copy link
Contributor Author

@stsewd can you review it?

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there are still some places to update

https://github.com/readthedocs/readthedocs.org/blob/master/docs/development/buildenvironments.rst
https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/settings/dev.py

Returns supported versions for the ``DOCKER_DEFAULT_VERSION`` if not

``settings.DOCKER_ENABLE`` is used)

If :py:data:`settings.DOCKER_ENABLE` is true, build documentation inside a

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Iamshankhadeep
Copy link
Contributor Author

Nice 2 work done. now lets focus on new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move our application settings to a READTHEDOCS prefix on our settings
4 participants