-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RTD prefix for docker only in setting.py and all other places where is needed #6040
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…pass all the tests
2a33e53
to
90328f2
Compare
@stsewd can you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there are still some places to update
https://github.com/readthedocs/readthedocs.org/blob/master/docs/development/buildenvironments.rst
https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/settings/dev.py
readthedocs.org/readthedocs/config/config.py
Line 282 in 0034c1a
Returns supported versions for the ``DOCKER_DEFAULT_VERSION`` if not |
readthedocs.org/readthedocs/projects/tasks.py
Line 374 in 0034c1a
``settings.DOCKER_ENABLE`` is used) |
If :py:data:`settings.DOCKER_ENABLE` is true, build documentation inside a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Nice 2 work done. now lets focus on new issues. |
fixes #5586