Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project count on homepage #6028

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Remove project count on homepage #6028

merged 3 commits into from
Aug 1, 2019

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Aug 1, 2019 •
edited
Loading

This query is causing a lot of load, currently.

@davidfischer davidfischer requested a review from a team August 1, 2019 19:11
agjohnson
agjohnson approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets follow up with a note maybe on the commented line -- or I'd be +1 on just removing project listing queries entirely from the front page

@davidfischer
Copy link
Contributor Author

I'll remove it entirely. Seems not very useful and rather expensive.

@agjohnson agjohnson merged commit 93bcf8d into master Aug 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the davidfischer/hotfix-remove-projects-count branch August 1, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @agjohnson