Change rtfd to readthedocs #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
requested changes
Jul 1, 2019
docs/automatic-redirects.rst
Outdated
| @@ -20,10 +20,10 @@ The reasoning behind this is that RTD organizes the URLs for docs so that multip | |||
|
|
|||
| Among all the multiple versions of docs, you can choose which is the "default" version for RTD to display, which usually corresponds to the git branch of the most recent official release from your project. | |||
|
|
|||
| rtfd.org | |||
| readthedocs.org | |||
There was a problem hiding this comment.
What are PO files here? We can add them to .gitignore right?
There was a problem hiding this comment.
And, not, those should live in repo, but not modified in this PR
There was a problem hiding this comment.
@stsewd I've made the changes, can you check now?
saadmk11
reviewed
Jul 2, 2019
pranay414
force-pushed
the
update-rtfd-to-readthedocs
branch
from
289df4d to
7b47af4
Compare
stsewd
reviewed
Jul 2, 2019
docs/automatic-redirects.rst
Outdated
| @@ -23,7 +23,7 @@ Among all the multiple versions of docs, you can choose which is the "default" v | |||
| rtfd.org | |||
| ~~~~~~~~ | |||
|
|
|||
| Links to rtfd.org are treated the same way as above. | |||
| Links to readthedocs.org are treated the same way as above. | |||
stsewd
reviewed
Jul 2, 2019
docs/custom_domains.rst
Outdated
| @@ -117,7 +117,7 @@ An example nginx configuration for pip would look like: | |||
| } | |||
| } | |||
|
|
|||
| rtfd.org | |||
| readthedocs.org | |||
stsewd
reviewed
Jul 2, 2019
|
@stsewd can you list down what all needs to be changed? The issue description seems vague to me. |
|
You should revert the changes in all .po files, and also revert the changes on domain names (rtfd.org) |
pranay414
force-pushed
the
update-rtfd-to-readthedocs
branch
from
7b47af4 to
c0097df
Compare
|
@stsewd I've made the required changes. Please review. |
dojutsu-user
approved these changes
Jul 3, 2019
stsewd
approved these changes
Jul 3, 2019
saadmk11
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue: #5870