-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call mkdocs using -m #5542
Call mkdocs using -m #5542
Conversation
There are some cases were rtd uses the old installed version of mkdocs instead of the one installed by the user, like in readthedocs#5532 (comment) Which gives an error because it's using a yaml file supported only in new mkdocs versions. This is similar to readthedocs#5107
This was added since 0.15 mkdocs/mkdocs@bcb88ab#diff-872c8dbf5130934d0765867735f24482 (2015). So I think we are safe to use it. |
What's the problem behind this PR and what's the solution? How does |
Is the description. #5532 (comment) when a user uses I'm guessing this also fixes the issue in the corporate site. Calling using You can replicate this locally by setting the |
More details are in the other linked PR #5107 |
👍 Please, add this explanation as a comment in the code so it's clear next time we read that part of the code. |
Well, we already use this form for all commands, except sphinx, it doesn't support |
None of the other commands have a comment about the reason. Please, add the comment. It doesn't bother us at all and it will help all the contributors in the future. |
There are some cases were rtd uses the old installed version of mkdocs
instead of the one installed by the user, like in
#5532 (comment)
Which gives an error because it's using a yaml file
supported only in new mkdocs versions.
This is similar to #5107