Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed Issue #5327 #5383

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Addressed Issue #5327 #5383

merged 2 commits into from
Mar 8, 2019

Conversation

rshrc
Copy link
Contributor

@rshrc rshrc commented Mar 1, 2019 •
edited by stsewd
Loading

Deleted allow_email and also the function get_contribution_details() function in core/models.py

Close #5327

@rshrc
Addressed Issue readthedocs#5327
3f2f62d 
Deleted allow_email and also the function get_contribution_details() function in core/models.py
@stsewd stsewd added the PR: work in progress Pull request is not ready for full review label Mar 5, 2019
@rshrc
Removed new line at the end of core/models.py which was causing an error
fab0ae2 
Linting problem 1 fixed, pushing to find new error in code
@ericholscher ericholscher requested a review from a team March 5, 2019 16:43
humitos
humitos approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

The PR is marked as "Work in progress", though. Are you still working on it or is it ready to merge?

@rshrc
Copy link
Contributor Author

rshrc commented Mar 5, 2019

Yes this is ready to merge. Thanks for the review.

@stsewd stsewd removed the PR: work in progress Pull request is not ready for full review label Mar 5, 2019
@stsewd stsewd mentioned this pull request Mar 5, 2019
Closed
@stsewd stsewd merged commit bb4c639 into readthedocs:master Mar 8, 2019
@stsewd stsewd mentioned this pull request Mar 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshrc @humitos @stsewd