-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweek css for sphinx_prompt #5281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
But, it is unclear to me that what problem does it addresses.
Can you also please post a screenshot of the changes.
If you will use another symbol in a prompt, a function of the prompt will generate another span class with next number, and after all your custom CSS will break the text size.
The second call of the prompt call break the text (size is different), because of : Thank you for your review! |
Thanks for the explanation, this looks like only affect to our docs, but looks like a good fix |
Also, can you please rebase/merge master? The test failure was already fixed there |
Can you please explain better, what I need to do? Thank you! |
@ovc in your branch execute
|
@stsewd my changes was already merged in master. I already done another commit. I'm sorry, but I can't understand what I need to do with this trevis error. |
@ovc
When you are in a separate branch, you can follow the instructions above to merge |
@dojutsu-user thank you for your explanation, I merged the changes from upstream/master for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. 👍
Fix for sphinx_prompt CSS, if you call sphinx_prompt with different prompt sign after previous call.