Suppress progress bar of the conda command. #5094
Conversation
The progress bar generates too much output, may be the cause of failure in readthedocs#5093.
|
Somehow who is capable about pip shall look into the q argument of pip installed packages, which may suffer from the same issue. |
|
I was just searching for an issue about this (or to open one myself), because I was having the same problem of truncated output. This indeed makes it difficult to see if everything was successful or not. |
The tests were trying to match the exact commandlines.
|
Let's see if this fix works. The test seems to be more strict than asserting the functionality, but I guess there are no better alternatives in this situation. |
There was a problem hiding this comment.
I'm on the fence after talking a look how the --quiet affects the conda env command. I'd like another @rtfd/core to review this and give him opinion.
I believe this is the direction to go though, because we will later add #5006 in the end so, we will have a complete list of what's installed in the environment.
| @@ -355,6 +355,7 @@ def setup_base(self): | |||
| 'conda', | |||
| 'env', | |||
| 'create', | |||
| '--quiet', | |||
There was a problem hiding this comment.
I think we don't want --quiet here. It made sense the first time I read the docs, but @jorisvandenbossche made me realized that it does not show all the packages installed either (only when called with conda env). More discussion here #5099 (comment)
There was a problem hiding this comment.
Note that without --quiet, it also does not show all the packages installed. It only shows the download progress output. In some way you can derive from that the installed packages, but only for short package names (otherwise the name and certainly the version is truncated), and it is also in a very unreadable way (compared to conda list or the way conda create lists the packages to be installed).
So given that, I would personally still be in favor of using --quiet here, as it simply removes somewhat non-useful output.
There was a problem hiding this comment.
See eg the output of the conda env create step in https://readthedocs.org/projects/geopandas/builds/8384815/: for quite some of the packages in the download progress, you can't see the full version, and for some not even the full package name.
There was a problem hiding this comment.
You are right!
So, merging this since it's the right direction to go. I'd love a contribution of #5099 soon, so we complete this output :)
The progress bar generates too much output, may be the cause of failure in #5093.