Fire a signal for domain verification (eg. for SSL) #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Jan 7, 2019
readthedocs/projects/tasks.py
Outdated
| @@ -1393,3 +1394,17 @@ def finish_inactive_builds(): | |||
| 'Builds marked as "Terminated due inactivity": %s', | |||
| builds_finished, | |||
| ) | |||
|
|
|||
|
|
|||
| @app.task | |||
There was a problem hiding this comment.
I suppose that you should pass queue='web' since we are accessing the database from inside the task.
| @@ -726,7 +727,14 @@ def get_success_url(self): | |||
|
|
|||
|
|
|||
| class DomainList(DomainMixin, ListViewWithForm): | |||
| pass | |||
| def get_context_data(self, **kwargs): | |||
There was a problem hiding this comment.
I think it's better to put this code under get method, don't you think?
There was a problem hiding this comment.
I think that would be worse, actually. We need access to the domain_list from the context. The get method both calls get_context_data and consumes the context (but doesn't return it). As a result, we'd have to replace get and not merely call the super method and add functionality. Does that make sense?
|
Pushed a commit to fix my only issue. This is 👍 for shipping. |
delete-merged-branch
bot
deleted the
davidfischer/domain-verification-retry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a few issues where domains have taken a long time to issue SSL certificates (example #4736 (comment)). Cloudflare -- who provides our SSL certs for custom domains -- automatically retries verification requests but they have an exponential backoff and then they stop retrying after a couple weeks. That means that if you add your domain to RTD and then don't fix your DNS for a day or two, it can take days to verify your domain. Users could of course remove the domain from RTD and re-add it but few people seem to do that.
This PR fires a task which fires signals which are handled in the cloudflare code (not in the readthedocs.org repo) to automatically retry verification whenever somebody visits the domain list screen (
/dashboard/<project_slug>/domains/)