More hints for invalid submodules #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Dec 17, 2018
| ) | ||
| check_output(['git', 'add', '.'], env=env) | ||
| check_output(['git', 'commit', '-m"Add submodule"'], env=env) | ||
|
|
||
| # Add a relative submodule URL in the relativesubmodule branch | ||
| check_output(['git', 'checkout', '-b', 'relativesubmodule', 'master'], env=env) |
There was a problem hiding this comment.
This wasn't creating the submodule as expected, and we have add_submodule_without_cloning now.
There was a problem hiding this comment.
The previous test was passing bc we were creating the branch from one that already had a submodule
humitos
reviewed
Dec 18, 2018
humitos
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are showing which submodules need to be fixed.
Related to #4043