Remove unused project model fields

[dojutsu-user]

Fixes #4866

[codecov]

Codecov Report

Merging #4870 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4870      +/-   ##
==========================================
- Coverage   76.93%   76.79%   -0.15%     
==========================================
  Files         158      158              
  Lines       10038     9932     -106     
  Branches     1259     1241      -18     
==========================================
- Hits         7723     7627      -96     
+ Misses       1981     1973       -8     
+ Partials      334      332       -2

Impacted Files	Coverage Δ
readthedocs/builds/models.py	78.83% <ø> (+0.41%)	⬆️
readthedocs/projects/version_handling.py	91.83% <ø> (-2.76%)	⬇️
readthedocs/restapi/views/model_views.py	95.12% <ø> (+0.96%)	⬆️
readthedocs/projects/views/private.py	80.05% <ø> (-0.06%)	⬇️
readthedocs/restapi/serializers.py	97.43% <ø> (ø)	⬆️
readthedocs/projects/constants.py	100% <ø> (ø)	⬆️
readthedocs/projects/forms.py	79.66% <ø> (ø)	⬆️
readthedocs/projects/models.py	85.55% <100%> (+0.11%)	⬆️
readthedocs/projects/admin.py	91.5% <100%> (ø)	⬆️

[dojutsu-user]

@humitos
Please review.

[humitos]

LGTM! Thanks.

I'd wait for another one to take a look at this PR before merging because it has an impact in the database.

[stsewd]

We can remove more code, like

https://github.com/rtfd/readthedocs.org/blob/3bfec170bdfb63e0f06b9bcd8300cb19e5981b75/readthedocs/projects/constants.py#L32-L45

[stsewd]

https://github.com/rtfd/readthedocs.org/blob/3bfec170bdfb63e0f06b9bcd8300cb19e5981b75/readthedocs/projects/forms.py#L218-L219

https://github.com/rtfd/readthedocs.org/blob/3bfec170bdfb63e0f06b9bcd8300cb19e5981b75/readthedocs/projects/views/private.py#L129-L129

https://github.com/rtfd/readthedocs.org/blob/3bfec170bdfb63e0f06b9bcd8300cb19e5981b75/readthedocs/projects/models.py#L751-L766

And more related code that uses the functions/methods above ^

[dojutsu-user]

@stsewd
Should we remove this test file?

    readthedocs.org/readthedocs/rtd_tests/tests/test_supported.py

I think, this is no longer needed

[stsewd]

@dojutsu-user seems safe to remove

[dojutsu-user]

@stsewd
There's a job error in Travis.
Is it related to this PR?

[stsewd]

Just restarted the job. I'm not sure if this PR is ready for review, but there is more code to remove.

[dojutsu-user]

@stsewd
Can you please review it again?

[stsewd]

This is a lot of code removed 🎉, I rebased to master and built a project locally and the versions didn't explode.

[humitos]

@agjohnson why did you mark it as "Work in progress"? It seems that it's ready to be merged.

[ericholscher]

This brings me great joy. Being the person who originally implemented supported versions, they never worked well for the majority of use cases, and were way too confusing for users. 💯

The only thing we need to think about here is the deployment. Because we're deleting a bunch of fields, it will break the webs during deploy, so we should make sure to deploy the webs in quick succession.

[stsewd]

We need to fix the migrations

[dojutsu-user]

I have edited and renamed the migrations file.

[ericholscher]

Thanks for this PR @dojutsu-user 💯 !