Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'VerisionLockedTimeout' to 'VersionLockedError' in comment. #4859

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Change 'VerisionLockedTimeout' to 'VersionLockedError' in comment. #4859

merged 1 commit into from
Nov 5, 2018

Conversation

dojutsu-user
Copy link
Member

Fixes a typo.

RichardLitt
RichardLitt approved these changes Nov 4, 2018
View reviewed changes
Copy link
Member

@RichardLitt RichardLitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Travis error unrelated.

stsewd
stsewd approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is unrelated, but looks like a flaky test, maybe?

@codecov
Copy link

codecov bot commented Nov 5, 2018 •
edited
Loading

Codecov Report

Merging #4859 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4859   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files         158      158           
  Lines        9990     9990           
  Branches     1262     1262           
=======================================
  Hits         7634     7634           
  Misses       2016     2016           
  Partials      340      340
Impacted Files Coverage Δ
readthedocs/projects/tasks.py 69.31% <ø> (ø) ⬆️

@ericholscher ericholscher merged commit 8fb8438 into readthedocs:master Nov 5, 2018
@ericholscher
Copy link
Member

Thanks @dojutsu-user -- you've been doing a bunch of great work recently!

@dojutsu-user
Copy link
Member Author

@ericholscher Thanks for the appreciation and thanks to RTD community for helping me so much.

@dojutsu-user dojutsu-user deleted the fix-typo-in-comments-tasks branch November 8, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@RichardLitt RichardLitt RichardLitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dojutsu-user @ericholscher @RichardLitt @stsewd