Allow use of file:// urls in repos during development.
#4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4801 +/- ##
=========================================
Coverage ? 76.26%
=========================================
Files ? 158
Lines ? 9984
Branches ? 1262
=========================================
Hits ? 7614
Misses ? 2025
Partials ? 345
|
stsewd
reviewed
Oct 24, 2018
| valid_schemes = public_schemes | ||
| if allow_private_repos: | ||
| valid_schemes += private_schemes | ||
| if getattr(settings, 'DEBUG'): # allow `file://` urls in dev |
There was a problem hiding this comment.
We can add this line here if we don't need tests for this
https://github.com/rtfd/readthedocs.org/blob/7b4784108dd09ef71c6d127e45ce46ae05315bc3/.coveragerc#L15-L19
I use git daemon for local dev https://github.com/stsewd/dotfiles/blob/45183539e77fe2b9323eaa41477f1bbe12fe8a23/gitconfig#L12-L15
There was a problem hiding this comment.
I use git daemon for local dev
Neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4061