Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to SSL for Custom Domains fixed #4766

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Link to SSL for Custom Domains fixed #4766

merged 1 commit into from
Oct 16, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 16, 2018

No description provided.

@humitos humitos requested a review from a team October 16, 2018 11:45
ericholscher
ericholscher approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool if we could use intersphinx in this context somehow. We build a feature with intersphinx redirects in the past, wouldn't be hard to do again for cases like this, so we could semantically link to a section.

@ericholscher ericholscher mentioned this pull request Oct 16, 2018
Closed
@ericholscher ericholscher merged commit 604e1fa into master Oct 16, 2018
@stsewd stsewd deleted the humitos/ssl-link/fixed branch October 16, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher