-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide explaining how to keep compatibility with mkdocs #4726
Conversation
a01c249
to
83f5600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some comments
docs/guides/mkdocs-old-versions.rst
Outdated
@@ -0,0 +1,75 @@ | |||
Keep building docs with old version of MkDocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use title case for titles
docs/guides/mkdocs-old-versions.rst
Outdated
|
||
You should check that your docs continue building in any of these cases: | ||
|
||
* your project doesn't have a ``requirements.txt`` file pinning ``mkdocs`` to an specific version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
-> a
83f5600
to
7147ac5
Compare
@stsewd thanks! I took your comments. |
@davidfischer please, when you have some time, take a look at this PR since you were helping me to understand the underlying problem and find the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this guide is a good one. I do have a few thoughts:
- We should probably strongly recommend that people pin versions of mkdocs. The same problem may arise when we upgrade from 0.17 -> 1.x.
- This guide has time-sensitive information. In a year, this guide will probably not be needed and in 2 years it definitely won't be. What's the plan for deprecating and removing it?
- We should crosslink to the docs for specifying requirements
docs/guides/mkdocs-old-versions.rst
Outdated
Keep Building Docs With Old Version Of MkDocs | ||
============================================= | ||
|
||
Recent changes on ``mkdocs`` forced us to `upgrade the default version installed`_ by Read the Docs and this may be a breaking change for your documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on -> to
|
||
Upgrade how extension arguments are defined | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually couldn't find exactly where this syntax changed. I tested building docs with the old method in 0.15 and they still didn't build. Maybe this was a change in a markdown parser? I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you pin Markdown
also to some version? I didn't, and I had to upgrade this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Maybe this changed underneath mkdocs.
27fe741
to
fdc3927
Compare
Good points!
What do you think about adding a warning note in https://docs.readthedocs.io/en/latest/builds.html#mkdocs (at the bottom of the section) like this: .. warning::
We strongly recommend to :ref:`pin the MkDocs version <guides/specifying-dependencies:Specifying Dependencies>`
used for your project to build the docs to avoid potential future incompatibilities. This way, if the user select MkDocs for his docs we are warning and pointing him to the right section about how to specify a dependency (which in the near future will be able from the YAML without needing a requirements.txt file). On the other hand, supposing that we would have had this note in that place, the error would have happened again since in this particular case we need to pin other packages also :/. This note, will be helpful under "some" circuntances only.
I don't really have a plan :( It's hard to remove the time-sensitive information since the user does know anything about the MkDocs version installed right now (because it's done automatically by RTD). So, talking about "Migrating from 0.15 version to X.X" or similar doesn't make too much sense to me. They don't really know that they strictly depend on I was thinking on this guide like a temporal solution to point users if they open issues around this and/or to communicate via email to our .com customers. This guide could probably completely removed some months after we notify our users/customers I'd say since it will become useless.
I added a new commit for this. |
Sounds good to me. |
Guide to help users that weren't pinning a version of
mkdocs
but were relying onmkdocs==0.15
. Since we upgrade our default version installed, they will find that their docs are not building anymore.This guide helps them to keep building their docs on Read the Docs showing the workarounds needed.
I'm not really happy with the document and how it's written but I think it communicates what we need.
Related to #4041 and #4556