Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused package nilsimsa #4697

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Remove unused package nilsimsa #4697

merged 1 commit into from
Oct 2, 2018

Conversation

browniebroke
Copy link
Contributor

Fixes #4104

stsewd
stsewd reviewed Oct 1, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

We still need to wait for tests to pass on master

@browniebroke
Copy link
Contributor Author

Ok, ping me when/if I should update my branch. Thanks.

@ericholscher ericholscher merged commit 5030ec4 into readthedocs:master Oct 2, 2018
@ericholscher
Copy link
Member

Thanks! 🎉

@browniebroke browniebroke deleted the cleanup-nilsimsa branch October 2, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@browniebroke @ericholscher @stsewd