Change mentions of "CNAME" -> custom domain #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some related cleanup of copy around the CNAME -> custom domain changes.
docs/features.rst
Outdated
| @@ -65,4 +65,4 @@ We provide full-text search across all of the pages of documentation hosted on o | |||
| Alternate Domains | |||
| ----------------- | |||
|
|
|||
| We provide support for CNAMEs, subdomains, and a shorturl for your project as well. This is outlined in the :doc:`alternate_domains` section. | |||
| We provide support for customer domains, subdomains, and a shorturl for your project as well. This is outlined in the :doc:`alternate_domains` section. | |||
RichardLitt
reviewed
Sep 10, 2018
docs/symlinks.rst
Outdated
| CNAMEs add a bit of difficulty, | ||
| because at the nginx layer we don't know what documentation to serve. | ||
| Custom domains add a bit of difficulty, | ||
| because at the Nginx layer we don't know what documentation to serve. |
There was a problem hiding this comment.
I think only the company is capitalized. On the nginx website, it is consistently lower-cased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNAME refers to a DNS construct, not an RTD construct. Referring to these as
"custom domain" instead makes this information easier to understand/find.
Also includes some random cleanup of copy around the CNAME -> custom domain
changes.