Add a flag to disable docsearch #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
approved these changes
Aug 24, 2018
|
I checked in the compiled version. I'll do a squash and merge. |
davidfischer
added a commit
that referenced
this pull request
Aug 25, 2018
* Add a flag to disable docsearch * Disable Docsearch with a feature on READTHEDOCS_DATA * Make the comment clearer * Checkin compiled built assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a JS flag under
READTHEDOCS_DATAfor disabling docsearch.Longer term, there will be a server side staff-only feature flag which sets the same variable. Ideally this feature can completely go away once the search improvements are deployed.
Related to #4452.