Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: mark more strings for translation #4438

Merged
merged 1 commit into from
Oct 31, 2018
Merged

search: mark more strings for translation #4438

merged 1 commit into from
Oct 31, 2018

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jul 27, 2018

No description provided.

humitos
humitos approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@humitos humitos requested a review from safwanrahman July 27, 2018 14:32
@humitos
Copy link
Member

humitos commented Jul 27, 2018

@safwanrahman can you take a look at this file? I know that you were working on the search. These changes don't look too complicated but maybe this file won't exist anymore or similar. You know that :)

safwanrahman
safwanrahman reviewed Jul 27, 2018
View reviewed changes
readthedocs/templates/search/elastic_search.html
@@ -79,7 +79,7 @@ <h5>Version</h5>

{% if facets.taxonomy %}

<h5>Taxonomy</h5>
<h5>{% trans 'Taxonomy' %}</h5>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed. as we never did Taxonomy and it will be removed

@safwanrahman
Copy link
Member

thanks @humitos for mentioning me.
This file will exist in the search upgrade, but I am hesitate to merge this before we deploy our new upgraded search. The template is changed in the new search, so I think we can hold this PR untill our search_upgrade branch merged into master.

@safwanrahman safwanrahman added this to the Search improvements milestone Jul 27, 2018
@xrmx
Copy link
Contributor Author

xrmx commented Jul 27, 2018

Please either merge this now, cherry-pick in your branch, close the pr but don't expect me to respin sometime in the future when some branch will merge, thanks.

@safwanrahman
Copy link
Member

@xrmx I have added this PR to the search Improvement milestone, so it will not get lost. If you want to merge it now, then you can open the PR against search_upgrade branch.

@safwanrahman safwanrahman changed the base branch from master to search_upgrade July 27, 2018 14:52
@safwanrahman safwanrahman changed the base branch from search_upgrade to master July 27, 2018 14:52
@humitos humitos added the Status: blocked Issue is blocked on another issue label Aug 15, 2018
@ericholscher
Copy link
Member

Gonna merge this, as it's useful, and the search upgrade is blocked currently :(

@ericholscher ericholscher merged commit 9917933 into readthedocs:master Oct 31, 2018
@ericholscher
Copy link
Member

Thanks @xrmx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safwanrahman safwanrahman safwanrahman left review comments

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
Status: blocked Issue is blocked on another issue
Projects
None yet
Milestone
Search improvements
Development

Successfully merging this pull request may close these issues.
4 participants
@xrmx @humitos @safwanrahman @ericholscher